fix(cli): broken java init template#13988
Merged
mergify[bot] merged 2 commits intomasterfrom Apr 6, 2021
Merged
Conversation
Change the java init templates to not call the stack builder classes and instead call the generated stack class constructor. Change the structure of the comments to correctly allow uncommenting in order to pass env config if needed. fix: #13964
|
|
NetaNir
reviewed
Apr 6, 2021
Contributor
NetaNir
left a comment
NetaNir
left a comment
There was a problem hiding this comment.
What about the sample app templates?
...k/lib/init-templates/v1/app/java/src/main/java/com/myorg/%name.PascalCased%App.template.java
Show resolved
Hide resolved
NetaNir
approved these changes
Apr 6, 2021
NetaNir
added
the
pr-linter/exempt-test
Contributor
Author
|
@Mergifyio refresh |
Contributor
|
Command
|
Contributor
Author
|
The sample app templates didn't get these changes originally but we can unify those to include all of these comments as well in another PR. |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
rix0rrr
added a commit
that referenced
this pull request
Apr 6, 2021
The Java init templates were recently fixed to use `new` instead of the builder, because the builder would instantiate the wrong class (`Stack` instead of `MyStack`) (#13988). However, the structure was changed to have 3 different `new` calls in 3 different comment blocks. Change it back to the old structure: there is one instantiation, and uncommenting just passes or doesn't pass the `env` property. Except this time we use `new` instead of the builder.
mergify bot
pushed a commit
that referenced
this pull request
Apr 6, 2021
The Java init templates were recently fixed to use `new` instead of the builder, because the builder would instantiate the wrong class (`Stack` instead of `MyStack`) (#13988). However, the structure was changed to have 3 different `new` calls in 3 different comment blocks. Change it back to the old structure: there is one instantiation, and uncommenting just passes or doesn't pass the `env` property. Except this time we use `new` instead of the builder. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
Change the java init templates to not call the stack builder classes and instead call the generated stack class constructor. Change the structure of the comments to correctly allow uncommenting in order to pass env config if needed. fix: aws#13964 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
The Java init templates were recently fixed to use `new` instead of the builder, because the builder would instantiate the wrong class (`Stack` instead of `MyStack`) (aws#13988). However, the structure was changed to have 3 different `new` calls in 3 different comment blocks. Change it back to the old structure: there is one instantiation, and uncommenting just passes or doesn't pass the `env` property. Except this time we use `new` instead of the builder. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the java init templates to not call the stack builder classes and
instead call the generated stack class constructor. Change the structure
of the comments to correctly allow uncommenting in order to pass env
config if needed.
fix: #13964
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license